fix maven dependency plugin warnings #340
Conversation
Awambeng
commented
Jul 24, 2024
Awambeng
commented
- add used undeclared dependencies
- remove all unused declared dependencies
fix: add used undeclared dependencies to solve warning
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #340 +/- ##
=============================================
+ Coverage 86.14% 86.76% +0.62%
Complexity 1 1
=============================================
Files 165 164 -1
Lines 3348 3348
Branches 217 217
=============================================
+ Hits 2884 2905 +21
+ Misses 330 309 -21
Partials 134 134 ☔ View full report in Codecov by Sentry. |
datasafe-rest-impl/pom.xml
Outdated
| <groupId>jakarta.validation</groupId> | ||
| <artifactId>jakarta.validation-api</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
What is the reason to exclude jakarta.validation-api and then add it separately?
datasafe-rest-impl/pom.xml
Outdated
| <groupId>com.amazonaws</groupId> | ||
| <artifactId>aws-java-sdk-core</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
What is the reason to exclude com.amazonaws dependencies and then add them again?
If there are maven-dependency-plugin warnings, please add ignoredUsedUndeclaredDependencies in plugin configuration.
datasafe-rest-impl/pom.xml
Outdated
| <groupId>com.fasterxml.jackson.core</groupId> | ||
| <artifactId>jackson-databind</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
That makes no sense. If there are plugin warnings, then add ignore in plugin configuration.
datasafe-rest-impl/pom.xml
Outdated
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-actuator-autoconfigure</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
please don't exclude from starters, add ignore in plugin configuration
datasafe-rest-impl/pom.xml
Outdated
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
please don't exclude, add ignore in plugin configuration
datasafe-rest-impl/pom.xml
Outdated
| <groupId>org.springframework.security</groupId> | ||
| <artifactId>spring-security-core</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
please don't exclude, add ignore in plugin configuration
| <groupId>com.amazonaws</groupId> | ||
| <artifactId>aws-java-sdk-core</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
please don't exclude, add ignore in plugin configuration
| <groupId>org.jetbrains</groupId> | ||
| <artifactId>annotations</artifactId> | ||
| </exclusion> | ||
| </exclusions> |
There was a problem hiding this comment.
makes no sense. assertj-core doesn't include jetbrains annotation
…moving unused declared dependencies
|
|
looks good to me @max402 |
